Fixes keyring = False not honored. #927
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
j-bennet
force-pushed
the
j-bennet/keyring-honor-config
branch
from
8b7ceeb
to
9063f02
Compare
Codecov Report
@@ Coverage Diff @@
## master #927 +/- ##
=========================================
+ Coverage 85.09% 85.1% +<.01%
=========================================
Files 22 22
Lines 2442 2443 +1
=========================================
+ Hits 2078 2079 +1
Misses 364 364
Continue to review full report at Codecov.
|
|
Looks good. 🐘 |
|
oh boy... didn't test this, I'm sorry... Thanks for fixing! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fix for #920.
Checklist
changelog.rst.AUTHORSfile (or it's already there).