Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix for pgcli --list. #952

Merged
merged 2 commits into from Oct 3, 2018
Merged

Fix for pgcli --list. #952

merged 2 commits into from Oct 3, 2018

Conversation

j-bennet
Copy link
Contributor

@j-bennet j-bennet commented Oct 2, 2018 •
edited

Description

Fix for #951.

Checklist

  • I've added this contribution to the changelog.rst.
  • I've added my name to the AUTHORS file (or it's already there).

@j-bennet j-bennet force-pushed the j-bennet/bugfix-list-command branch from 5fc0ee0 to 09e707a Compare October 2, 2018 04:35
@j-bennet j-bennet force-pushed the j-bennet/bugfix-list-command branch 3 times, most recently from 773349f to dda7997 Compare October 2, 2018 06:17
@j-bennet j-bennet changed the title Fix for pgcli --list. [WIP] Fix for pgcli --list. Oct 2, 2018
@j-bennet
Copy link
Contributor Author

j-bennet commented Oct 2, 2018 •
edited

Not ready to merge yet because of test failures.

Tests are now fixed.

@codecov-io
Copy link

codecov-io commented Oct 2, 2018 •
edited

Codecov Report

Merging #952 into master will decrease coverage by 0.4%.
The diff coverage is 75%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #952      +/-   ##
==========================================
- Coverage   84.55%   84.14%   -0.41%     
==========================================
  Files          21       21              
  Lines        2454     2460       +6     
==========================================
- Hits         2075     2070       -5     
- Misses        379      390      +11
Impacted Files Coverage Δ
pgcli/main.py 75.43% <75%> (-1.4%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ec5131e...872b958. Read the comment docs.

@j-bennet j-bennet force-pushed the j-bennet/bugfix-list-command branch from df8148c to 872b958 Compare October 2, 2018 07:14
@j-bennet j-bennet changed the title [WIP] Fix for pgcli --list. Fix for pgcli --list. Oct 2, 2018
@j-bennet j-bennet merged commit fcf0eb0 into master Oct 3, 2018
@j-bennet j-bennet deleted the j-bennet/bugfix-list-command branch October 3, 2018 00:10
@laixintao laixintao mentioned this pull request Mar 12, 2020
Closed
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maxrothman maxrothman maxrothman approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@j-bennet @codecov-io @maxrothman