Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix bad f-string placement on describe_one_table_details #150

Merged
merged 1 commit into from
Apr 26, 2024

Conversation

saucoide
Copy link
Contributor

Description

The string is split in 2 and and concatenated implicitly, but the f-string is applied only to the first one, which has no variables to replace, while the second one does and inserts a literal {oid}

this is breaking \d on patterns with a pg syntax error e.g:

\d mytabl*

Checklist

  • I've added this contribution to the changelog.rst.
  • I installed pre-commit hooks (pip install pre-commit && pre-commit install), and ran black on my code.
  • Please squash merge this pull request (uncheck if you'd like us to merge as multiple commits)

@j-bennet
Copy link
Contributor

Thank you @saucoide . Feel free to add your contribution to changelog.

The string is split in 2 and and concatenated implicitly, but the f-string is applied only to the first one, which has no variables to replace, while the second one does and inserts a literal `{oid}`

this is breaking `\d` on patterns with a pg syntax error e.g:

`\d mytabl*`
@saucoide
Copy link
Contributor Author

@j-bennet done - added it as "upcoming" since there is no unreleased version to add it to, hope that works

@j-bennet j-bennet merged commit 25a8e15 into dbcli:main Apr 26, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants