generated from spatie/package-skeleton-laravel
-
-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[BREAKING] Code refactoring #37
Open
frugan-dev
wants to merge
14
commits into
dbfx:master
Choose a base branch
from
frugan-dev:master
base: master
Could not load branches
Branch not found: {{ refName }}
Could not load tags
Nothing to show
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
updated all composer packages restored STRAPI_URL revised esceptions classes
Stubbs
approved these changes
Mar 4, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me. The new queryParams means I don't have to re-implement my changes that introduced filters to the collection method.
Hi @dbfx, is there any problem accepting this pull request? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DONE
getResponse()
$response
returned byCache::remember()
https://stackoverflow.com/a/74783008/3929620$response->throw()
Illuminate\Http\Client\RequestException
Http::withToken()
instead ofHttp::withHeaders()
Http::withQueryParameters()
instead ofhttp_build_query()
Http::withOptions()
andHttp::baseUrl()
$type
to$name
, as it is more consistent with the field used by Strapi$queryData
to$queryParams
, as it is more consistent withHttp::withQueryParameters()
$sortKey
,$sortOrder
,$populate
, etc.) in favor of$queryParams
, which allows greater control over the API parameters used$queryParams
also allows you to use pagination by offset values (pagination[start]
andpagination[limit]
), which previously conflicted with pagination by page values (pagination[page]
andpagination[limit]
) set directly within the methodcollection()
$cacheTime
parameter to override the global value defined inSTRAPI_CACHE_TIME
per-callcollectionCount()
method, as the/api/$name/count
entrypoint does not seem to exist anymore in Strapi v4 (?), and also thepagination[withCount]
parameter exists and it's active by defaultentriesByField()
method as it is superfluous, because it is possible to make the same call with thecollection()
method (see examples inREADME
)STRAPI_FULL_URLS
globally in.env
file$pluck
parameter as it is superfluous to the primary functionality of this package: everyone is free to alter the response as they wishconfig('strapi.pagination.limit')
from 20 to 25 (default Strapipagination[pageSize]
)README
fileTODO
README
? this could be included in this section, useful for those who have a local development setup (e.g. mkcert):