Skip to content

Commit

Permalink
removed uuid dependency from api package
Browse files Browse the repository at this point in the history
  • Loading branch information
janproch committed May 20, 2024
1 parent 134d8d1 commit 153f40f
Show file tree
Hide file tree
Showing 18 changed files with 20 additions and 38 deletions.
1 change: 0 additions & 1 deletion integration-tests/__tests__/alter-database.spec.js
Original file line number Diff line number Diff line change
@@ -1,7 +1,6 @@
const stableStringify = require('json-stable-stringify');
const _ = require('lodash');
const fp = require('lodash/fp');
const uuidv1 = require('uuid/v1');
const { testWrapper } = require('../tools');
const engines = require('../engines');
const { getAlterDatabaseScript, extendDatabaseInfo, generateDbPairingId } = require('dbgate-tools');
Expand Down
3 changes: 1 addition & 2 deletions integration-tests/__tests__/alter-table.spec.js
Original file line number Diff line number Diff line change
@@ -1,7 +1,6 @@
const stableStringify = require('json-stable-stringify');
const _ = require('lodash');
const fp = require('lodash/fp');
const uuidv1 = require('uuid/v1');
const { testWrapper } = require('../tools');
const engines = require('../engines');
const { getAlterTableScript, extendDatabaseInfo, generateDbPairingId } = require('dbgate-tools');
Expand Down Expand Up @@ -76,7 +75,7 @@ describe('Alter table', () => {
tbl.columns.push({
columnName: 'added',
dataType: 'int',
pairingId: uuidv1(),
pairingId: crypto.randomUUID(),
notNull: false,
autoIncrement: false,
});
Expand Down
3 changes: 1 addition & 2 deletions packages/api/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -57,8 +57,7 @@
"rimraf": "^3.0.0",
"simple-encryptor": "^4.0.0",
"ssh2": "^1.11.0",
"tar": "^6.0.5",
"uuid": "^3.4.0"
"tar": "^6.0.5"
},
"scripts": {
"start": "env-cmd node src/index.js --listen-api",
Expand Down
3 changes: 1 addition & 2 deletions packages/api/src/controllers/archive.js
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,6 @@ const socket = require('../utility/socket');
const loadFilesRecursive = require('../utility/loadFilesRecursive');
const getJslFileName = require('../utility/getJslFileName');
const { getLogger } = require('dbgate-tools');
const uuidv1 = require('uuid/v1');
const dbgateApi = require('../shell');
const jsldata = require('./jsldata');
const platformInfo = require('../utility/platformInfo');
Expand Down Expand Up @@ -127,7 +126,7 @@ module.exports = {
return true;
}

const tmpchangedFilePath = path.join(resolveArchiveFolder(folder), `${file}-${uuidv1()}.jsonl`);
const tmpchangedFilePath = path.join(resolveArchiveFolder(folder), `${file}-${crypto.randomUUID()}.jsonl`);
const reader = await dbgateApi.modifyJsonLinesReader({
fileName: changedFilePath,
changeSet,
Expand Down
3 changes: 1 addition & 2 deletions packages/api/src/controllers/auth.js
Original file line number Diff line number Diff line change
@@ -1,14 +1,13 @@
const axios = require('axios');
const jwt = require('jsonwebtoken');
const getExpressPath = require('../utility/getExpressPath');
const uuidv1 = require('uuid/v1');
const { getLogins } = require('../utility/hasPermission');
const { getLogger } = require('dbgate-tools');
const AD = require('activedirectory2').promiseWrapper;

const logger = getLogger('auth');

const tokenSecret = uuidv1();
const tokenSecret = crypto.randomUUID();

function shouldAuthorizeApi() {
const logins = getLogins();
Expand Down
3 changes: 1 addition & 2 deletions packages/api/src/controllers/databaseConnections.js
Original file line number Diff line number Diff line change
@@ -1,4 +1,3 @@
const uuidv1 = require('uuid/v1');
const connections = require('./connections');
const archive = require('./archive');
const socket = require('../utility/socket');
Expand Down Expand Up @@ -137,7 +136,7 @@ module.exports = {

/** @param {import('dbgate-types').OpenedDatabaseConnection} conn */
sendRequest(conn, message) {
const msgid = uuidv1();
const msgid = crypto.randomUUID();
const promise = new Promise((resolve, reject) => {
this.requests[msgid] = [resolve, reject];
try {
Expand Down
3 changes: 1 addition & 2 deletions packages/api/src/controllers/files.js
Original file line number Diff line number Diff line change
@@ -1,4 +1,3 @@
const uuidv1 = require('uuid/v1');
const fs = require('fs-extra');
const path = require('path');
const { filesdir, archivedir, resolveArchiveFolder, uploadsdir, appdir } = require('../utility/directories');
Expand Down Expand Up @@ -164,7 +163,7 @@ module.exports = {

generateUploadsFile_meta: true,
async generateUploadsFile({ extension }) {
const fileName = `${uuidv1()}.${extension || 'html'}`;
const fileName = `${crypto.randomUUID()}.${extension || 'html'}`;
return {
fileName,
filePath: path.join(uploadsdir(), fileName),
Expand Down
5 changes: 2 additions & 3 deletions packages/api/src/controllers/runners.js
Original file line number Diff line number Diff line change
@@ -1,7 +1,6 @@
const _ = require('lodash');
const path = require('path');
const fs = require('fs-extra');
const uuidv1 = require('uuid/v1');
const byline = require('byline');
const socket = require('../utility/socket');
const { fork } = require('child_process');
Expand Down Expand Up @@ -165,7 +164,7 @@ module.exports = {

start_meta: true,
async start({ script }) {
const runid = uuidv1();
const runid = crypto.randomUUID()

if (script.type == 'json') {
const js = jsonScriptToJavascript(script);
Expand Down Expand Up @@ -213,7 +212,7 @@ module.exports = {
loadReader_meta: true,
async loadReader({ functionName, props }) {
const promise = new Promise((resolve, reject) => {
const runid = uuidv1();
const runid = crypto.randomUUID();
this.requests[runid] = [resolve, reject];
this.startCore(runid, loaderScriptTemplate(functionName, props, runid));
});
Expand Down
3 changes: 1 addition & 2 deletions packages/api/src/controllers/serverConnections.js
Original file line number Diff line number Diff line change
@@ -1,7 +1,6 @@
const connections = require('./connections');
const socket = require('../utility/socket');
const { fork } = require('child_process');
const uuidv1 = require('uuid/v1');
const _ = require('lodash');
const AsyncLock = require('async-lock');
const { handleProcessCommunication } = require('../utility/processComm');
Expand Down Expand Up @@ -201,7 +200,7 @@ module.exports = {
},

sendRequest(conn, message) {
const msgid = uuidv1();
const msgid = crypto.randomUUID();
const promise = new Promise((resolve, reject) => {
this.requests[msgid] = [resolve, reject];
try {
Expand Down
3 changes: 1 addition & 2 deletions packages/api/src/controllers/sessions.js
Original file line number Diff line number Diff line change
@@ -1,5 +1,4 @@
const _ = require('lodash');
const uuidv1 = require('uuid/v1');
const connections = require('./connections');
const socket = require('../utility/socket');
const { fork } = require('child_process');
Expand Down Expand Up @@ -85,7 +84,7 @@ module.exports = {

create_meta: true,
async create({ conid, database }) {
const sesid = uuidv1();
const sesid = crypto.randomUUID();
const connection = await connections.getCore({ conid });
const subprocess = fork(
global['API_PACKAGE'] || process.argv[1],
Expand Down
3 changes: 1 addition & 2 deletions packages/api/src/controllers/uploads.js
Original file line number Diff line number Diff line change
@@ -1,6 +1,5 @@
const path = require('path');
const { uploadsdir } = require('../utility/directories');
const uuidv1 = require('uuid/v1');
const { getLogger } = require('dbgate-tools');
const logger = getLogger('uploads');

Expand All @@ -15,7 +14,7 @@ module.exports = {
res.json(null);
return;
}
const uploadName = uuidv1();
const uploadName = crypto.randomUUID();
const filePath = path.join(uploadsdir(), uploadName);
logger.info(`Uploading file ${data.name}, size=${data.size}`);

Expand Down
3 changes: 1 addition & 2 deletions packages/api/src/proc/sessionProcess.js
Original file line number Diff line number Diff line change
@@ -1,4 +1,3 @@
const uuidv1 = require('uuid/v1');
const path = require('path');
const fs = require('fs');
const _ = require('lodash');
Expand Down Expand Up @@ -31,7 +30,7 @@ class TableWriter {
}

initializeFromQuery(structure, resultIndex) {
this.jslid = uuidv1();
this.jslid = crypto.randomUUID();
this.currentFile = path.join(jsldir(), `${this.jslid}.jsonl`);
fs.writeFileSync(
this.currentFile,
Expand Down
3 changes: 1 addition & 2 deletions packages/api/src/shell/download.js
Original file line number Diff line number Diff line change
@@ -1,11 +1,10 @@
const path = require('path');
const uuidv1 = require('uuid/v1');
const { uploadsdir } = require('../utility/directories');
const { downloadFile } = require('../utility/downloader');

async function download(url) {
if (url && url.match(/(^http:\/\/)|(^https:\/\/)/)) {
const tmpFile = path.join(uploadsdir(), uuidv1());
const tmpFile = path.join(uploadsdir(), crypto.randomUUID());
await downloadFile(url, tmpFile);
return tmpFile;
}
Expand Down
5 changes: 2 additions & 3 deletions packages/api/src/utility/DatastoreProxy.js
Original file line number Diff line number Diff line change
@@ -1,5 +1,4 @@
const { fork } = require('child_process');
const uuidv1 = require('uuid/v1');
const { handleProcessCommunication } = require('./processComm');
const processArgs = require('../utility/processArgs');
const pipeForkLogs = require('./pipeForkLogs');
Expand Down Expand Up @@ -67,7 +66,7 @@ class DatastoreProxy {

async getRows(offset, limit) {
await this.ensureSubprocess();
const msgid = uuidv1();
const msgid = crypto.randomUUID();
const promise = new Promise((resolve, reject) => {
this.requests[msgid] = [resolve, reject];
try {
Expand All @@ -81,7 +80,7 @@ class DatastoreProxy {
}

async notifyChangedCore() {
const msgid = uuidv1();
const msgid = crypto.randomUUID();
const promise = new Promise((resolve, reject) => {
this.requests[msgid] = [resolve, reject];
try {
Expand Down
3 changes: 1 addition & 2 deletions packages/api/src/utility/JsonLinesDatabase.js
Original file line number Diff line number Diff line change
@@ -1,6 +1,5 @@
const AsyncLock = require('async-lock');
const fs = require('fs-extra');
const uuidv1 = require('uuid/v1');

const lock = new AsyncLock();

Expand Down Expand Up @@ -57,7 +56,7 @@ class JsonLinesDatabase {
? obj
: {
...obj,
_id: uuidv1(),
_id: crypto.randomUUID(),
};
this.data.push(elem);
await this._save();
Expand Down
3 changes: 1 addition & 2 deletions packages/api/src/utility/JsonLinesDatastore.js
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,6 @@ const stableStringify = require('json-stable-stringify');
const { evaluateCondition } = require('dbgate-sqltree');
const requirePluginFunction = require('./requirePluginFunction');
const esort = require('external-sorting');
const uuidv1 = require('uuid/v1');
const { jsldir } = require('./directories');
const LineReader = require('./LineReader');

Expand All @@ -28,7 +27,7 @@ class JsonLinesDatastore {
}

static async sortFile(infile, outfile, sort) {
const tempDir = path.join(os.tmpdir(), uuidv1());
const tempDir = path.join(os.tmpdir(), crypto.randomUUID());
fs.mkdirSync(tempDir);

await esort
Expand Down
5 changes: 2 additions & 3 deletions packages/api/src/utility/downloadPackage.js
Original file line number Diff line number Diff line change
@@ -1,7 +1,6 @@
// const pacote = require('pacote');
const axios = require('axios');
// const tarballExtract = require('tarball-extract');
const uuidv1 = require('uuid/v1');
const path = require('path');
const fs = require('fs');
const zlib = require('zlib');
Expand Down Expand Up @@ -38,9 +37,9 @@ async function downloadPackage(packageName, directory) {

const tarball = infoResp.data.versions[latest].dist.tarball;

const tmpFile = path.join(uploadsdir(), uuidv1() + '.tgz');
const tmpFile = path.join(uploadsdir(), crypto.randomUUID() + '.tgz');
await downloadFile(tarball, tmpFile);
const tmpDir = path.join(uploadsdir(), uuidv1());
const tmpDir = path.join(uploadsdir(), crypto.randomUUID());
fs.mkdirSync(tmpDir);
await extractTarball(tmpFile, tmpDir);
await copyDirectory(path.join(tmpDir, 'package'), directory);
Expand Down
3 changes: 1 addition & 2 deletions packages/api/src/utility/sshTunnelProxy.js
Original file line number Diff line number Diff line change
@@ -1,5 +1,4 @@
const { getLogger } = require('dbgate-tools');
const uuidv1 = require('uuid/v1');
const { getSshTunnel } = require('./sshTunnel');
const logger = getLogger('sshTunnelProxy');

Expand All @@ -22,7 +21,7 @@ function handleGetSshTunnelResponse({ msgid, response }, subprocess) {

async function getSshTunnelProxy(connection) {
if (!process.send) return getSshTunnel(connection);
const msgid = uuidv1();
const msgid = crypto.randomUUID();
process.send({ msgtype: 'getsshtunnel-request', msgid, connection });
return new Promise((resolve, reject) => {
dispatchedMessages[msgid] = { resolve, reject };
Expand Down

0 comments on commit 153f40f

Please sign in to comment.