Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FEAT: Make Ctrl + P and other searches fuzzy #246

Closed
KBulmer opened this issue Mar 17, 2022 · 5 comments
Closed

FEAT: Make Ctrl + P and other searches fuzzy #246

KBulmer opened this issue Mar 17, 2022 · 5 comments

Comments

@KBulmer
Copy link

KBulmer commented Mar 17, 2022

Is your feature request related to a problem? Please describe.
Finding tables is time consuming and unintuitive.

Describe the solution you'd like
Fuzzy search. A query like "pltr" should suggest the table PlaylistTrack.

Additional info
Ctrl + P in VSCode clearly demonstrates what kind of search I'm looking for.

@janproch
Copy link
Member

Interseting idea, thanks.

Already now is possible to search multiple substrings (almost fuzzy...), if you type "pl tr", it will find PlaylistTrack
I will consider this, so that space delimiting will be not neccessary

@superDuperCyberTechno
Copy link

Ctrl-P also seems to have an unintended side effect where it includes databases in a cluster even though I have ticked "Use only database (...)" in the "Add connection" modal.

In addition, Ctrl-P also only seems to include tables from the currently active database. It would be doubly awesome if it included all databases (respecting my first point) as well as all tables within them.

IE: Say I'm in database A, table B and I need to go to database B, table C. - In my dream scenario I would simply slap Ctrl-P and write "b.c" and hit enter.

janproch added a commit that referenced this issue Mar 24, 2022
@janproch
Copy link
Member

Fuzzy search implemented in v. 4.7.4

Also fixed problem with including other databases, when connection is marked as single-database

Searching in other databases with Ctrl+P is now not easy, because it will require to load table list from other databases. Maybe it could be done with client-side structure caching (using similar trick, as when you search db name in disconnected server connections). I will consider this...

@janproch janproch closed this as completed Jun 2, 2022
@janproch janproch reopened this Dec 16, 2022
@janproch
Copy link
Member

This should be reconsidered, search results are now too big (feedback from more users)

Probably fuzzy search should be used only in Ctrl+P search, and it should also sort results by relevance

@janproch
Copy link
Member

janproch commented Jan 6, 2023

Better fuzzy search released in 5.2.0

@janproch janproch closed this as completed Jan 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants