Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FEAT: Folders support #274

Closed
I2rys opened this issue Apr 26, 2022 · 18 comments
Closed

FEAT: Folders support #274

I2rys opened this issue Apr 26, 2022 · 18 comments
Labels
Released in BETA solved Pushed into GIT, but not yet released (after release issue will be closed)

Comments

@I2rys
Copy link

I2rys commented Apr 26, 2022

Is your feature request related to a problem? Please describe.
It's quiet annoying If you have a lot of database to manage mostly If you can't organize & filter them(The color's is not enough too).

Describe the solution you'd like
Being able to create folders(Create, Delete, Rename) and drag & drop databases on them, basicly just like a normal file explorer.

Describe alternatives you've considered
Being able to use tags and filter tags.

@GitClickOk
Copy link

You can name it "Tags" or "Groups" too. But "Folders" is great too if we can have subfolders.

@wallysonn
Copy link

Sua solicitação de recursos está relacionada a um problema? Por favor, descreva. É silencioso irritante Se você tem um monte de banco de dados para gerenciar principalmente Se você não pode organizá-los e filtrar(A cor não é suficiente também).

Descreva a solução que você gostaria de ser capaz de criar pastas (Criar, excluir, renomear) e arrastar e soltar bancos de dados neles, basicamente como um explorador de arquivos normal.

Descreva alternativas que você considerou ser capaz de usar tags e etiquetas de filtro.

Please, this is very important.

@qlaffont
Copy link

qlaffont commented Nov 3, 2022

I'm starting to work on it but it seems that svelte transpilation is not working. @janproch

src/tabs/DiagramTab.svelte
27: export let conid;
28: export let database;
29: export let initialArgs;
               ^
30: export const activator = createActivator('DiagramTab', true);
31: $: setEditorData($modelState.value);
[!] (plugin svelte) CssSyntaxError: /home/quentin/Documents/dev/qlaffont/dbgate/packages/web/src/Screen.svelte:1:3: Unknown word
src/Screen.svelte
CssSyntaxError: /home/quentin/Documents/dev/qlaffont/dbgate/packages/web/src/Screen.svelte:1:3: Unknown word
    at Input.error (/home/quentin/Documents/node_modules/postcss/lib/input.js:148:16)
    at Parser.unknownWord (/home/quentin/Documents/node_modules/postcss/lib/parser.js:540:22)
    at Parser.other (/home/quentin/Documents/node_modules/postcss/lib/parser.js:164:12)
    at Parser.parse (/home/quentin/Documents/node_modules/postcss/lib/parser.js:72:16)
    at parse (/home/quentin/Documents/node_modules/postcss/lib/parse.js:11:12)
    at new LazyResult (/home/quentin/Documents/node_modules/postcss/lib/lazy-result.js:133:16)
    at Processor.process (/home/quentin/Documents/node_modules/postcss/lib/processor.js:28:14)
    at transformer (/home/quentin/Documents/dev/qlaffont/dbgate/node_modules/svelte-preprocess/dist/transformers/globalStyle.js:62:72)
    at transform (/home/quentin/Documents/dev/qlaffont/dbgate/node_modules/svelte-preprocess/dist/autoProcess.js:37:12)
    at style (/home/quentin/Documents/dev/qlaffont/dbgate/node_modules/svelte-preprocess/dist/autoProcess.js:191:33)


[2022-11-03 08:17:36] waiting for changes...

-> https://github.com/qlaffont/dbgate

@janproch
Copy link
Member

janproch commented Nov 3, 2022

Hm, I haven't seen similar error yet.

Has it ever worked before for you? And what command do for starting UI you use? yarn start:web ?

@qlaffont
Copy link

qlaffont commented Nov 3, 2022

It was the first time I start the project, And yes i have started the server with yarn start:web
node version : v14.18.2

@janproch
Copy link
Member

janproch commented Nov 3, 2022

I use node version 16.14.2 now, but it shouldn't depend on it

And did you install your dependencies with yarn install or npm install ?
And what OS are you using?

@qlaffont
Copy link

qlaffont commented Nov 3, 2022

I will try to retry with your node-version yarn install

@qlaffont
Copy link

qlaffont commented Nov 3, 2022

seems to not work too ...

@jan-prochazka-themama-ai

Which OS are you using?

@qlaffont
Copy link

qlaffont commented Nov 3, 2022

Static hostname: pop-os
Icon name: computer-laptop
Chassis: laptop
Operating System: Pop!_OS 22.04 LTS (Based on Ubuntu)
Kernel: Linux 6.0.3-76060003-generic
Architecture: x86-64
Hardware Vendor: Dell Inc.
Hardware Model: XPS 15 9500

@janproch
Copy link
Member

janproch commented Nov 3, 2022

I tried it with clean clone on my Ubuntu now, and it works. But there are lot of warnings from Svelte, maybe some of them could cause errors in some situations, so I will try to eliminate these warnings, I will let you know then.

@janproch janproch pinned this issue Nov 3, 2022
@janproch
Copy link
Member

janproch commented Nov 3, 2022

OK, decided to upgrade to newest Svelte toolkit, but I got stuck in this

Anyway, I came across the same problem, that you encountered, and I believe, that it is solved it newest master

@qlaffont
Copy link

qlaffont commented Nov 4, 2022

Works thanks, I will try to work on it ^^

@janproch
Copy link
Member

janproch commented Nov 7, 2022

Folders feature is now released in BETA, thanks @qlaffont

@qlaffont
Copy link

qlaffont commented Nov 8, 2022

@janproch as I tested on beta. Parent field is working and d-and works for me.

As I can see for d-and-d, we should be able to add connection to parent if we drag it to sub child list.
Because at this time, you can add it only if you drop on parent name.

janproch added a commit that referenced this issue Nov 10, 2022
janproch added a commit that referenced this issue Nov 10, 2022
@janproch
Copy link
Member

D&D is now fixed.

I have also changed the way, how new folder is created. I added new button for this in connection list.

So I have removed "Parent folder" field in connection details, as it is a bit user unfriendly to creating folders as side effect of editing connections. But I am open to discuss this topic, this modification is in a standalone commit, so it is easy to revrt this modification.

@qlaffont
Copy link

For me it's the perfect integration 👌

@janproch janproch added the solved Pushed into GIT, but not yet released (after release issue will be closed) label Nov 10, 2022
@janproch
Copy link
Member

Released in 5.1.6, thanks @qlaffont

@janproch janproch unpinned this issue Nov 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Released in BETA solved Pushed into GIT, but not yet released (after release issue will be closed)
Projects
None yet
Development

No branches or pull requests

6 participants