Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

True Strike not affected by Strike Dummy #165

Closed
johnplunk opened this issue Nov 17, 2019 · 2 comments
Closed

True Strike not affected by Strike Dummy #165

johnplunk opened this issue Nov 17, 2019 · 2 comments
Labels
bug Something isn't working Character: Wanderer Related to The Wanderer

Comments

@johnplunk
Copy link
Contributor

True Strike does not respect Strike Dummy buff.

Probably something to do with the "lose hp" workaround that it does?
@dbjorge
Copy link
Owner

dbjorge commented Nov 17, 2019

This is probably 2 different issues; I think it's probably missing the STRIKE card tag it ought to have, but also it probably wouldn't work right anyway until #54 is fixed. Thanks for calling it out, I'd forgotten about the first part!

@dbjorge dbjorge added bug Something isn't working Character: Wanderer Related to The Wanderer labels Nov 17, 2019
dbjorge added a commit that referenced this issue Nov 17, 2019
@dbjorge
Add missing STRIKE tag to Smithing Strike and True Strike (partial fi…
288ea7c 
…x for #165)
@dbjorge dbjorge mentioned this issue Nov 18, 2019
Closed
@dbjorge
Copy link
Owner

dbjorge commented Nov 18, 2019

Fixed the strike tagging, converging other true strike issues into #54

@dbjorge dbjorge closed this as completed Nov 18, 2019
dbjorge pushed a commit that referenced this issue Mar 1, 2020
@neablis-7
Merge pull request #165 from neablis-7/neablis-7-patch-1
df33630 
Add files via upload
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working Character: Wanderer Related to The Wanderer
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@dbjorge @johnplunk