Update dependencies & Dockerfile #217

swiknaba · 2023-11-28T14:53:06Z

Tested locally:

build docker image ✅
run docker image ✅
send HTML to the endpoint ✅
verify the returned Base64 string is a valid PDF ✅

After merge

create release v1.2.0
push new tag to Dockerhub

swiknaba · 2023-11-28T15:59:26Z

src/utils/generator.ts

@@ -45,6 +48,9 @@ export default class Generator {
      }
    }

+    // https://developer.chrome.com/articles/new-headless/
+    puppeteerOptions.headless = 'new'


I've done several tests locally, and with this option, PDFs are generated much faster.

swiknaba added 13 commits November 28, 2023 15:30

docker: use latest node LTS

33db4db

docker: cleanup, don't compile dev dependencies, ..

2637e5e

update all prod dependencies

ab36ffb

bump version of this repo 1.1.1 -> 1.2

a8ec8eb

Update yarn.lock

edcbc94

clean up readme

fa8cc78

bump versions on CircleCi

722744e

CI: try booting docker & hit endpoints

dc6f882

cache docker layers

a183d72

ping docker in the same run that launches it

05a5496

skip running curl on circlci again

7aa591b

use the new headless mode

4298330

log an error if we fail to generate a PDF

43c9520

swiknaba marked this pull request as ready for review November 28, 2023 15:58

swiknaba requested review from bruno-goncalves and samkahchiin November 28, 2023 15:58

swiknaba assigned bruno-goncalves and samkahchiin Nov 28, 2023

swiknaba commented Nov 28, 2023

View reviewed changes

Update CHANGELOG.md

8fd633e

bruno-goncalves approved these changes Nov 28, 2023

View reviewed changes

dblworks assigned swiknaba and unassigned bruno-goncalves Nov 28, 2023

swiknaba merged commit c5ecb0d into main Nov 28, 2023
4 checks passed

swiknaba deleted the lud/updates branch November 28, 2023 16:20

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Update dependencies & Dockerfile #217

Update dependencies & Dockerfile #217

swiknaba commented Nov 28, 2023 •

edited

swiknaba Nov 28, 2023

Update dependencies & Dockerfile #217

Update dependencies & Dockerfile #217

Conversation

swiknaba commented Nov 28, 2023 • edited

After merge

swiknaba Nov 28, 2023

Choose a reason for hiding this comment

swiknaba commented Nov 28, 2023 •

edited