Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve healthchecks to ensure we can generate a PDF #218

Merged
merged 7 commits into from
Jan 30, 2024
Merged

Improve healthchecks to ensure we can generate a PDF #218

merged 7 commits into from
Jan 30, 2024

Conversation

puckzxz
Copy link
Contributor

@puckzxz puckzxz commented Jan 30, 2024

This improves the healthcheck endpoints by ensuring we can both launch puppeteer and generate a PDF with it

Also includes some smaller code cleanups

@puckzxz puckzxz requested a review from swiknaba January 30, 2024 21:38
swiknaba
swiknaba approved these changes Jan 30, 2024
View reviewed changes
Copy link
Contributor

@swiknaba swiknaba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@dblworks dblworks assigned puckzxz and unassigned swiknaba Jan 30, 2024
@swiknaba swiknaba merged commit 0e99129 into main Jan 30, 2024
4 checks passed
@swiknaba swiknaba deleted the chris/improve-healthcheck branch January 30, 2024 23:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@swiknaba swiknaba swiknaba approved these changes

Assignees

@puckzxz puckzxz

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@puckzxz @swiknaba