Use params validation.

dblock · Apr 4, 2014 · f60e3c5 · f60e3c5
1 parent d91500a
commit f60e3c5
Show file tree

Hide file tree

Showing 2 changed files with 14 additions and 5 deletions.
diff --git a/api/post_put.rb b/api/post_put.rb
@@ -12,8 +12,10 @@ class << self
       result = (PostPut.rang += 1)
       { rang: result }
     end
+    params do
+      requires :count, type: Integer
+    end
     put :ring do
-      error!("missing :count", 400) unless params[:count]
       result = (PostPut.rang += params[:count].to_i)
       { rang: result }
     end

diff --git a/spec/api/post_put_spec.rb b/spec/api/post_put_spec.rb
@@ -25,10 +25,17 @@ def app
       get "/api/ring"
       last_response.body.should == { rang: @rang + 2 }.to_json
     end
-    it "PUT ring" do
-      put "/api/ring?count=2"
-      last_response.status.should == 200
-      last_response.body.should == { rang: @rang + 2 }.to_json
+    context "PUT ring" do
+      it "succeeds for 2 rings" do
+        put "/api/ring?count=2"
+        last_response.status.should == 200
+        last_response.body.should == { rang: @rang + 2 }.to_json
+      end
+      it "fails with a missing ring" do
+        put "/api/ring"
+        last_response.status.should == 400
+        last_response.body.should == { error: 'count is missing' }.to_json
+      end
     end
   end
 end