Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update faraday to 2.7.10 #120

Merged
merged 1 commit into from
Aug 24, 2023
Merged

chore: update faraday to 2.7.10 #120

merged 1 commit into from
Aug 24, 2023

Conversation

esarmstrong
Copy link
Contributor

Faraday Middleware is deprecated with the release of Faraday 2.0. This PR removes the faraday-middleware gem, replacing needed middlewares with those bundled with Faraday 2.0 and faraday-multipart

@dblock
Copy link
Owner

dblock commented Aug 24, 2023

Thanks! Care to fix danger in this PR? I think the token has been rotated, you can copy the one from https://github.com/dblock/strava-ruby-client/blob/master/.github/workflows/danger.yml or https://github.com/dblock/ruby-enum/blob/master/.github/workflows/danger.yml

@esarmstrong
Copy link
Contributor Author

Thanks! Care to fix danger in this PR? I think the token has been rotated, you can copy the one from https://github.com/dblock/strava-ruby-client/blob/master/.github/workflows/danger.yml or https://github.com/dblock/ruby-enum/blob/master/.github/workflows/danger.yml

should be set with the strava token 👍

@dblock
Copy link
Owner

dblock commented Aug 24, 2023

Now it complains about a rate limit, I'll just merge.

@dblock dblock merged commit e01f013 into dblock:master Aug 24, 2023
6 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants