Bump to v0.4.0 and add UPGRADING docs #14
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dblock
reviewed
Jul 28, 2018
CHANGELOG.md
Outdated
|
|
||
| * Your contribution here. | ||
|
|
||
| ### 0.4.0 (2018/07/27) |
There was a problem hiding this comment.
This hasn't been released yet, so it shouldn't have a date and say 0.4.0 (Next).
dblock
reviewed
Jul 28, 2018
|
|
||
| #### All errors that return HTTP codes 400-600 result in a IEX::Errors::ClientError exception | ||
|
|
||
| On previous versions, calling `IEX::Resources::Chart.get` with an invalid option results on a |
There was a problem hiding this comment.
Reading this it's pretty clear that we're now doing something different in various API calls. I've opened #15 so that we can handle errors the same way in all methods (ie. raise IEX::Errors::ClientError on every Faraday::ClientError in all calls. Hopefully we don't need to copy paste that code everywhere and implement it in the base class.
|
Maybe try taking care of #15 first before we merge this? |
rodolfobandeira
force-pushed
the
prepare-release-0_4_0
branch
from
15735ed
to
83706c6
Compare
rodolfobandeira
force-pushed
the
prepare-release-0_4_0
branch
from
83706c6
to
93e0372
Compare
|
Perfect. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
close #13
If I understood well, since this release will be a major upgrade
(v0.4.0), the next version will actually bev0.4.1. I noticed on the git history that you @dblock and @jromanovs changed theversionin two commits, only after indeed releasing at rubygems.org. I already changed the version in advance but added tomorrow's release date.Please let me know if that makes sense.