Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dialogs not visible in fullscreen mode #114

Closed
D-Groenewegen opened this issue Oct 17, 2022 · 3 comments
Closed

Dialogs not visible in fullscreen mode #114

D-Groenewegen opened this issue Oct 17, 2022 · 3 comments

Comments

@D-Groenewegen
Copy link

When the Mirador viewer goes into fullscreen mode, everything else that's not contained below the element with class="fullscreen" will be hidden.

Unfortunately, this means that the popup dialogs of the ImageCropper and CanvasLink plugins, and maybe others, won't be visible when Mirador has been launched fullscreen.

I'm not sure if the dialog can be appended inside the div (easiest solution), or that this should happen only if you're in fullscreen mode.

@D-Groenewegen
Copy link
Author

Oh well, I just upgraded to the latest version, which was only slightly older, but that seems to have solved things for the ImageCropper plugin. The issue is still valid for CanvasLink. Do you want me to close this issue and open a new one over there?

@morpheus-87
Copy link
Member

Thank you for your issue! This bug was fixed in Version 0.1.3: https://github.com/dbmdz/mirador-imagecropper/blob/main/CHANGELOG.md#013---2021-11-02

Would be great, if you could open an issue on dbmdz/mirador-canvaslink.

@D-Groenewegen
Copy link
Author

Will do! And thanks again for this wonderful plugin.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants