Skip to content
This repository has been archived by the owner on Jun 21, 2022. It is now read-only.

Warn user when editing ingredients while recipe description is unsaved (or reverse) #144

Open
dboehmer opened this issue Jan 14, 2021 · 2 comments
Open

Warn user when editing ingredients while recipe description is unsaved (or reverse) #144

dboehmer opened this issue Jan 14, 2021 · 2 comments
Assignees
@moseschmiedel @tjfoerster
Labels
good first issue JavaScript

Comments

@dboehmer
Copy link
Owner

No description provided.

@dboehmer
Copy link
Owner Author

dboehmer commented Jan 19, 2021 •
edited
Loading

A user quite similar to persona Lina has just reported that both forms are now simultaneously saved with a click on a submit button. While using Coocook at the weekend I also felt like this myself. But I don’t know why this could have changed or how this should work. Needs to be verified at least.

@dboehmer
Copy link
Owner Author

The ingredient editor will update automatically with @moseschmiedel’s React Solid component.

So this becomes very simple: basic Javascript confirmation if the description/preparation is changed and the users tries to leave the page.

tjfoerster added a commit that referenced this issue May 18, 2022
@tjfoerster
#144 confirm if unsaved form changes
1a34401
@tjfoerster tjfoerster mentioned this issue May 18, 2022
Open
tjfoerster added a commit that referenced this issue May 31, 2022
@tjfoerster
(#144) bugfix and some changes
9351991
tjfoerster added a commit that referenced this issue May 31, 2022
@tjfoerster
(#144) add unsavedChanges.js to script.js
7eb56ce
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@moseschmiedel moseschmiedel

@tjfoerster tjfoerster

Labels
good first issue JavaScript
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@dboehmer @moseschmiedel @tjfoerster