Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Windows Fix #352

Merged
merged 4 commits into from
Mar 20, 2024
Merged

Windows Fix #352

merged 4 commits into from
Mar 20, 2024

Conversation

kraftp
Copy link
Contributor

@kraftp kraftp commented Mar 20, 2024

In ESM, modules must be imported as URLs. This is enforced more strictly on Windows. Thus, we now import operations.js as a file URL.

@kraftp kraftp merged commit f193708 into main Mar 20, 2024
2 checks passed
@kraftp kraftp deleted the kraftp/windows-fix branch March 20, 2024 18:43
qianl15 pushed a commit that referenced this pull request Mar 21, 2024
In ESM, modules must be imported [as
URLs](#352). This is enforced
more strictly on Windows. Thus, we now import `operations.js` as a file
URL.
@qianl15 qianl15 mentioned this pull request Mar 21, 2024
qianl15 added a commit that referenced this pull request Mar 21, 2024
In ESM, modules must be imported [as
URLs](#352). This is enforced
more strictly on Windows. Thus, we now import `operations.js` as a file
URL.

Co-authored-by: Peter Kraft <peter.kraft@dbos.dev>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants