Custom Body Parsers #353
Merged
Custom Body Parsers #353
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maxdml
reviewed
Mar 21, 2024
maxdml
reviewed
Mar 21, 2024
tests/httpServer/server.test.ts
Outdated
Comment on lines
80
to
84
| test("post-test-custom-body", async () => { | ||
| const response = await request(testRuntime.getHandlersCallback()).post("/testpost").set('Content-Type', 'application/custom-content-type').send(JSON.stringify({ name: "alice" })); | ||
| expect(response.statusCode).toBe(200); | ||
| expect(response.text).toBe("hello alice"); | ||
| }); |
There was a problem hiding this comment.
Can you also check the path with an ignored content type?
There was a problem hiding this comment.
Added, but it's more a test of Koa than of us
maxdml
approved these changes
Mar 21, 2024
kraftp
force-pushed
the
kraftp/custom-body-parser
branch
from
01458db
to
ecccbe9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR adding support for custom body parsers through the
@KoaBodyParserclass decorator. If set, this overrides the default body parser for all endpoints in its class.Example:
Addresses issue #350