API for the new paginated "get application logs" #391
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
qianl15
reviewed
Apr 19, 2024
| logger.info(`No logs found for the specified parameters`); | ||
| } else { | ||
| logger.info(`Successfully retrieved logs of application: ${appName}`); | ||
| logger.info(res.data) | ||
| console.log(logResponse.body.trimEnd()) |
There was a problem hiding this comment.
I changed this to console.log because logger.info adds its own [TIME][info]... prefix. These logs have a similar prefix already. So when paginating you'd see
[timestamp][info]: [inner_log_timestamp][info][body]
[inner_log_timestamp][info][body]
[inner_log_timestamp][info][body]
...
[timestamp][info]: [inner_log_timestamp][info][body]
[inner_log_timestamp][info][body]
[inner_log_timestamp][info][body]
I decided to essentially send the inner body of the logs to stdout "exactly as is". This seems most friendly for use cases like sending logs to some program for parsing. Does that make sense?
qianl15
approved these changes
Apr 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.