add the --report-unused-disable-directives to lint script #441
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you! One formatting nit is that This PR is also conflicting with main, please resolve conflicts. We will clean up eslint config. I filed an issue to track this. |
demetris-manikas
force-pushed
the
eslint-updates
branch
2 times, most recently
from
bde580d
to
c27ad7d
Compare
demetris-manikas
force-pushed
the
eslint-updates
branch
from
c27ad7d
to
1d383eb
Compare
|
I tried renaming eslintconfg.cjs to eslintconfg.js and immediately realized want you were talking about... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the --report-unused-disable-directives which removes all unused eslint disable directives.
It also adds a .eslintignore file that excludes the
.eslintrc.cjsfile.This is because after enabling the Microsoft eslint plugin in VSCode it complains about this
Many ways to solve it and I picked the easiest one.
Really why the
.cjsextension? why not.jsor '.json' ?