Revert "Reduce usage of "any" (#448)" #469
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 8f1b5d4.
maxdml
approved these changes
May 23, 2024
|
I just submitted a fix for that |
Unfortunately there were other issues, such as #463. More broadly, it's possible to write code like: Some apps have code like this (such as https://github.com/dbos-inc/dbos-demo-apps/tree/main/yky-social), and #448 broke them because those functions aren't generic any more. We shouldn't change public interface signatures in a non-backwards-compatible way. However, like I said, many of the changes in #448 were good (especially the internal changes) and we'd be happy to work with you to re-introduce them in smaller PRs. Thanks a lot for your contributions, we really appreciate them! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts commit 8f1b5d4 as it included breaking API changes. It caused numerous failures on our demo applications and in our staging environment and cannot be released in its current state. The changes in that PR are good, but we need to introduce them gradually and carefully (likely in multiple smaller PRs) and verify they don't cause regressions.