Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade eslint to version 9, and switch all eslint configs to the new flat format #510

Merged
merged 18 commits into from
Jun 13, 2024

Conversation

CaspianA1
Copy link
Contributor

@CaspianA1 CaspianA1 commented Jun 12, 2024

Changes:

  • Updates to package-lock.json files
  • Upgrade eslint to 9.4.0, and typescript-eslint (and its subpackages) to 8.0.0-alpha.30
  • Port the outermost .eslintrc.js to the new flat config format
  • Apply many new linter rules, and remove automatic linter fixes for now

Note: some pesky linter warnings remain when running the linter locally (although these warnings are not particularly relevant)

…hat makes the linter configs look a lot neater).

- Remove the excludes from the template tsconfig.json files (not needed there, since they're in the eslint.config.js files).
- Updates to package-lock.json files
- Upgrade eslint to 9.4.0, and typescript-eslint (and its subpackages) to 8.0.0-alpha.30
- Port the outermost .eslintrc.js to the new flat config format
- Apply many new linter rules, and remove automatic linter fixes for now

Still not working:
- Local tests are not fully passing
- Some pesky linter rules remain with Prisma
@CaspianA1 CaspianA1 requested a review from kraftp June 12, 2024 23:32
@CaspianA1 CaspianA1 force-pushed the CaspianA1/flat_config_linter_porting branch from 7cf57cf to e2cab1f Compare June 13, 2024 00:29
eslint.config.js Outdated Show resolved Hide resolved
package.json Outdated Show resolved Hide resolved
- Remove 2 no-longer-existing files from the outermost "ignores" in eslint.config.js
- Remove the typescript-eslint dependency from the outermost package.json, and move it into the templates' package.json files
- Reduce how many files I am ignoring in the templates' eslint.config.js files
…en plain + dev eslint dependencies for the templates. Also install typescript-eslint for the outermost package.json.
package.json Outdated Show resolved Hide resolved
@CaspianA1 CaspianA1 merged commit 67d6f94 into main Jun 13, 2024
2 checks passed
@CaspianA1 CaspianA1 deleted the CaspianA1/flat_config_linter_porting branch June 13, 2024 20:51
This was referenced Jun 13, 2024
@kraftp kraftp mentioned this pull request Jun 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants