-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade eslint to version 9, and switch all eslint configs to the new flat format #510
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…formatting in this project)
…hat makes the linter configs look a lot neater). - Remove the excludes from the template tsconfig.json files (not needed there, since they're in the eslint.config.js files).
- Updates to package-lock.json files - Upgrade eslint to 9.4.0, and typescript-eslint (and its subpackages) to 8.0.0-alpha.30 - Port the outermost .eslintrc.js to the new flat config format - Apply many new linter rules, and remove automatic linter fixes for now Still not working: - Local tests are not fully passing - Some pesky linter rules remain with Prisma
7cf57cf
to
e2cab1f
Compare
kraftp
reviewed
Jun 13, 2024
kraftp
reviewed
Jun 13, 2024
kraftp
reviewed
Jun 13, 2024
- Remove 2 no-longer-existing files from the outermost "ignores" in eslint.config.js - Remove the typescript-eslint dependency from the outermost package.json, and move it into the templates' package.json files - Reduce how many files I am ignoring in the templates' eslint.config.js files
…en plain + dev eslint dependencies for the templates. Also install typescript-eslint for the outermost package.json.
kraftp
reviewed
Jun 13, 2024
kraftp
reviewed
Jun 13, 2024
kraftp
approved these changes
Jun 13, 2024
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes:
Note: some pesky linter warnings remain when running the linter locally (although these warnings are not particularly relevant)