fixed: ModulesHostBuilder dosn't configures ModulesHost #28
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fw2568
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changed the way how the ModulesHost (building host) is configured due to issue #27:
ConfigureAppConfigurationwill configure ModulesHost and host of module.ConfigureServiceswill now also be applied to ModulesHost.This allows to us to use things like logging also within the Hosuto framework. It should on the other hand cause no harm, as these services are also applied to every module.
WebHostBuilderconfiguration will no longer overwrite host configuration.This was implemented by changing the call order of
ConfigureAppConfigurationandConfigureWebHostas documented here: UseEnvironment overwritten by ConfigureWebHostDefaults dotnet/runtime#47050