macOS fix #30
Merged
macOS fix #30
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We actually need to use
freeze_supportfor both Windows and macOS. This was surpring. I found that from checking some threads on stack overflow.freeze_supportshould in theory do nothing on Ubuntu, but I would just have it there for all operating systems, if it works.Also, it was recommended to move the
spawn_methodstuff to theif __name__ == "__main__"right after thefreeze_support.Just tested the binary installers on both Windows and macOS and seems to work!
We can refactor the code at a later stage. Now we are ready for the final tests on Ubuntu and then publish the release!