Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add the method of broadcasting mutation to json rpc #151

Merged
merged 10 commits into from
Nov 16, 2022

Conversation

imotai
Copy link
Contributor

@imotai imotai commented Nov 14, 2022

  • feature
  • unit test
  • document

more about this pr #149

@imotai imotai linked an issue Nov 14, 2022 that may be closed by this pull request
@imotai imotai closed this Nov 14, 2022
@imotai imotai reopened this Nov 14, 2022
@imotai imotai changed the title feat: shutdown db3 add broadcast mutation to json rpc Nov 14, 2022
@imotai imotai changed the title add broadcast mutation to json rpc add the method of broadcasting mutation to json rpc Nov 14, 2022
@imotai imotai added this to the M2 milestone Nov 15, 2022
@db3fans db3fans added the documentation Improvements or additions to documentation label Nov 15, 2022
@imotai
Copy link
Contributor Author

imotai commented Nov 16, 2022

@jingchen2222 please help me to review this PR

@jingchen2222
Copy link
Collaborator

@jingchen2222 please help me to review this PR

Sure. Will review it later today.

));
} else {
let err = "invalid parameters";
Err(json_rpc::ErrorData::new(-32602, err))
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what is -32602

Copy link
Collaborator

@jingchen2222 jingchen2222 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@imotai imotai merged commit 0ecf103 into main Nov 16, 2022
@imotai imotai deleted the 149-support-submitting-mutation-in-json-rpc branch November 23, 2022 07:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation PR-size-medium
Projects
None yet
Development

Successfully merging this pull request may close these issues.

support submitting mutation in rpc
4 participants