Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix:proto is not defined #250

Merged
merged 1 commit into from
Dec 25, 2022
Merged

fix:proto is not defined #250

merged 1 commit into from
Dec 25, 2022

Conversation

xiyangjun
Copy link
Collaborator

No description provided.

@db3fans
Copy link
Collaborator

db3fans commented Dec 24, 2022

This PR exceeds the recommended size of 1200 lines. Please make sure you are NOT addressing multiple issues with one PR. Note this PR might be rejected due to its size.

@codecov-commenter
Copy link

Codecov Report

Merging #250 (f5dd0d9) into main (128574c) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #250   +/-   ##
=======================================
  Coverage   53.34%   53.34%           
=======================================
  Files          41       41           
  Lines        3667     3667           
=======================================
  Hits         1956     1956           
  Misses       1711     1711           
Flag Coverage Δ
rust 53.34% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Contributor

@imotai imotai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@imotai imotai merged commit f101dcc into main Dec 25, 2022
@imotai imotai deleted the fix/db3js_build_error branch December 27, 2022 04:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants