Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/remove the generated code #254

Merged
merged 16 commits into from
Dec 29, 2022
Merged

Feat/remove the generated code #254

merged 16 commits into from
Dec 29, 2022

Conversation

imotai
Copy link
Contributor

@imotai imotai commented Dec 28, 2022

No description provided.

@db3fans
Copy link
Collaborator

db3fans commented Dec 28, 2022

This PR exceeds the recommended size of 1200 lines. Please make sure you are NOT addressing multiple issues with one PR. Note this PR might be rejected due to its size.

@codecov-commenter
Copy link

codecov-commenter commented Dec 28, 2022

Codecov Report

Merging #254 (9246183) into main (041fff8) will decrease coverage by 0.09%.
The diff coverage is 16.66%.

@@            Coverage Diff             @@
##             main     #254      +/-   ##
==========================================
- Coverage   54.83%   54.73%   -0.10%     
==========================================
  Files          41       41              
  Lines        3797     3800       +3     
==========================================
- Hits         2082     2080       -2     
- Misses       1715     1720       +5     
Flag Coverage Δ
rust 54.73% <16.66%> (-0.10%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/node/src/storage_node_impl.rs 0.57% <0.00%> (-0.01%) ⬇️
src/sdk/src/store_sdk.rs 94.83% <ø> (ø)
src/session/src/query_session_verifier.rs 93.33% <100.00%> (-0.13%) ⬇️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@db3fans
Copy link
Collaborator

db3fans commented Dec 28, 2022

This PR exceeds the recommended size of 1200 lines. Please make sure you are NOT addressing multiple issues with one PR. Note this PR might be rejected due to its size.

@db3fans
Copy link
Collaborator

db3fans commented Dec 28, 2022

This PR exceeds the recommended size of 1200 lines. Please make sure you are NOT addressing multiple issues with one PR. Note this PR might be rejected due to its size.

@db3fans
Copy link
Collaborator

db3fans commented Dec 28, 2022

This PR exceeds the recommended size of 1200 lines. Please make sure you are NOT addressing multiple issues with one PR. Note this PR might be rejected due to its size.

@db3fans
Copy link
Collaborator

db3fans commented Dec 29, 2022

This PR exceeds the recommended size of 1200 lines. Please make sure you are NOT addressing multiple issues with one PR. Note this PR might be rejected due to its size.

@db3fans
Copy link
Collaborator

db3fans commented Dec 29, 2022

This PR exceeds the recommended size of 1200 lines. Please make sure you are NOT addressing multiple issues with one PR. Note this PR might be rejected due to its size.

@db3fans
Copy link
Collaborator

db3fans commented Dec 29, 2022

This PR exceeds the recommended size of 1200 lines. Please make sure you are NOT addressing multiple issues with one PR. Note this PR might be rejected due to its size.

@db3fans
Copy link
Collaborator

db3fans commented Dec 29, 2022

This PR exceeds the recommended size of 1200 lines. Please make sure you are NOT addressing multiple issues with one PR. Note this PR might be rejected due to its size.

@db3fans
Copy link
Collaborator

db3fans commented Dec 29, 2022

This PR exceeds the recommended size of 1200 lines. Please make sure you are NOT addressing multiple issues with one PR. Note this PR might be rejected due to its size.

@db3fans
Copy link
Collaborator

db3fans commented Dec 29, 2022

This PR exceeds the recommended size of 1200 lines. Please make sure you are NOT addressing multiple issues with one PR. Note this PR might be rejected due to its size.

@db3fans
Copy link
Collaborator

db3fans commented Dec 29, 2022

This PR exceeds the recommended size of 1200 lines. Please make sure you are NOT addressing multiple issues with one PR. Note this PR might be rejected due to its size.

@db3fans
Copy link
Collaborator

db3fans commented Dec 29, 2022

This PR exceeds the recommended size of 1200 lines. Please make sure you are NOT addressing multiple issues with one PR. Note this PR might be rejected due to its size.

@db3fans
Copy link
Collaborator

db3fans commented Dec 29, 2022

This PR exceeds the recommended size of 1200 lines. Please make sure you are NOT addressing multiple issues with one PR. Note this PR might be rejected due to its size.

@imotai imotai merged commit 91b4101 into main Dec 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants