Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add multi signature scheme #275

Merged
merged 15 commits into from
Jan 19, 2023

Conversation

imotai
Copy link
Contributor

@imotai imotai commented Jan 11, 2023

Address example:0x0dc8e109d5dd2bee6746ca1d6fd9919659bdb28a

Signature base64 example:AZ0DU4T3WgMT2AWsczEus1Xl08Q1VsTZu6pPE0e1Op1LRqEz+FL+FgKjQDlVU3r6HAKBImJ3OyHZd4cHFudcbzABAhZubOzkI26ArLlTxnxFZSQy67JFBaPlrFJe6aTA58Lw

  • support ed25519 signature scheme
  • support secp256k1 signature scheme
  • update the verification of abci_impl
  • update the store sdk
  • update the db3js

@imotai imotai linked an issue Jan 11, 2023 that may be closed by this pull request
@imotai imotai changed the title feat: add multi signature schema feat: add multi signature scheme Jan 17, 2023
@codecov-commenter
Copy link

codecov-commenter commented Jan 18, 2023

Codecov Report

Merging #275 (e4ece28) into main (a078362) will increase coverage by 0.00%.
The diff coverage is 55.40%.

@@           Coverage Diff            @@
##             main     #275    +/-   ##
========================================
  Coverage   54.86%   54.87%            
========================================
  Files          41       48     +7     
  Lines        3820     4332   +512     
========================================
+ Hits         2096     2377   +281     
- Misses       1724     1955   +231     
Flag Coverage Δ
rust 54.87% <55.40%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/base/src/test_base.rs 100.00% <ø> (ø)
src/crypto/src/lib.rs 100.00% <ø> (ø)
src/error/src/lib.rs 100.00% <ø> (ø)
src/sdk/src/store_sdk.rs 94.76% <ø> (-0.07%) ⬇️
src/crypto/src/db3_public_key.rs 14.06% <14.06%> (ø)
src/crypto/src/db3_serde.rs 20.58% <20.58%> (ø)
src/crypto/src/db3_address.rs 21.31% <21.31%> (ø)
src/crypto/src/signature_scheme.rs 52.94% <52.94%> (ø)
src/crypto/src/key_derive.rs 61.90% <61.90%> (ø)
src/crypto/src/db3_keypair.rs 71.68% <71.68%> (ø)
... and 1 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@db3fans
Copy link
Collaborator

db3fans commented Jan 19, 2023

This PR exceeds the recommended size of 1200 lines. Please make sure you are NOT addressing multiple issues with one PR. Note this PR might be rejected due to its size.

@imotai imotai merged commit 2631c7e into main Jan 19, 2023
@imotai imotai deleted the 168-wip-use-the-ethereum-compatible-signature-method branch February 14, 2023 15:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

WIP: propose multi-chain signature methods
3 participants