Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/sdk readonly client #536

Merged
merged 26 commits into from Jul 2, 2023
Merged

Feat/sdk readonly client #536

merged 26 commits into from Jul 2, 2023

Conversation

imotai
Copy link
Contributor

@imotai imotai commented Jul 2, 2023


PR-Codex overview

This PR focuses on adding functionality and improving documentation for the db3.js library.

Detailed summary

  • Added DatabaseStatePersistence message to db3_database_v2.proto
  • Updated EventTable message in db3_database_v2.proto
  • Updated query.test.ts by changing the timeout from 1000ms to 2000ms
  • Updated types.ts by adding ReadClient to Client import
  • Updated README.md with additional documentation and links
  • Updated db_store_v2.rs by adding STATE_CF constant and implementing flush_state method
  • Updated db_store_v2.rs by adding CollectionState and DatabaseState structs
  • Updated db_store_v2.rs by updating the update_db_state_for_add_db method
  • Updated database_v2.ts by updating the getCollection, getDatabase, and showDatabase methods
  • Updated README.md with additional documentation and examples

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

@github-actions github-actions bot added documentation Improvements or additions to documentation PR-size-small labels Jul 2, 2023
@codecov-commenter
Copy link

codecov-commenter commented Jul 2, 2023

Codecov Report

Merging #536 (13be2b5) into main (1c8bce3) will decrease coverage by 0.01%.
The diff coverage is 50.00%.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

@@            Coverage Diff             @@
##             main     #536      +/-   ##
==========================================
- Coverage   55.39%   55.38%   -0.01%     
==========================================
  Files          72       72              
  Lines       13994    13998       +4     
  Branches       61       61              
==========================================
+ Hits         7752     7753       +1     
- Misses       6242     6245       +3     
Flag Coverage Δ
rust 55.38% <50.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/storage/src/db_store_v2.rs 60.20% <25.00%> (-0.21%) ⬇️
sdk/src/store/database_v2.ts 81.42% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@imotai imotai merged commit 4209cc6 into main Jul 2, 2023
8 checks passed
@imotai imotai deleted the feat/sdk_readonly_client branch July 24, 2023 01:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation PR-size-small
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants