Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't write weights file if existing file failed to load #13

Closed
dbr opened this issue Feb 3, 2016 · 0 comments
Closed

Don't write weights file if existing file failed to load #13

dbr opened this issue Feb 3, 2016 · 0 comments

Comments

@dbr
Copy link
Owner

dbr commented Feb 3, 2016

If there is an error while loading tabtabtab_weights.json, currently the file will be reset to default {} when next used.

This means a temporary file-access glitch or hand-editing typo results in all weights being lost, which is annoying

Instead the weights should only be written if a) loading the file was successful, or b) the file did not exist previously

dbr added a commit that referenced this issue Feb 4, 2016
@dbr dbr closed this as completed Mar 9, 2016
dbr added a commit that referenced this issue Apr 10, 2016
Fixes #14

Introduced in changes for #13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant