Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fable.Reaction needs a logo #6

Closed
dbrattli opened this issue Oct 29, 2018 · 23 comments
Closed

Fable.Reaction needs a logo #6

dbrattli opened this issue Oct 29, 2018 · 23 comments
Labels
help wanted Extra attention is needed

Comments

@dbrattli
Copy link
Owner

dbrattli commented Oct 29, 2018

Reaction/Fable.Reaction needs a logo. Perhaps something a mix or combo of the dragon and the electric eel? Do we need a separate logo for Reaction and Fable.Reaction, or could we have the same?
(#9)

Check out:

@dbrattli dbrattli added the help wanted Extra attention is needed label Oct 30, 2018
@alfonsogarciacaro
Copy link

I'm training my new design skills I've learned from @whitetigle, so here goes my first proposal. cc also @sergey-tihon

fable reaction

@alfonsogarciacaro
Copy link

@whitetigle Just in case you want to have a look, the Affinity Designer file is here

@dbrattli
Copy link
Owner Author

dbrattli commented Nov 2, 2018

They are dancing ❤

@sergey-tihon
Copy link
Contributor

sergey-tihon commented Nov 3, 2018

My wife did couple options

Option 2

rxv2

Option 3

rxv3

@alfonsogarciacaro
Copy link

Looks good @sergey-tihon! You gave an idea for another proposal, what about something along these lines?

fable reaction

@sergey-tihon
Copy link
Contributor

sergey-tihon commented Nov 4, 2018

We can also mix colors on our options

Option 5

rxv6

Option 6

rxv5

Option 7

rxv7

@dbrattli
Copy link
Owner Author

dbrattli commented Nov 4, 2018

@sergey-tihon please say thanks to your wife from me. This is great and could actually solve 2 problems:

  • Option 2 looks like Reaction. Reaction is the core tech behind Fable.Reaction and basically just plain Async Rx. But it's F# and carefully written to work with Fable. Reaction runs anywhere, .NET, Fable (Node, Web) so it makes sense to me that the logo for Reaction is Rx red.
  • Option 3 looks like Fable.Reaction. Fable.Reaction is the specific use of Reaction within Fable and Elmish. Thus it's much more on the Fable side than Reaction, and it makes sense to me that the logo for Fable.Reaction is Fable blue.

@sergey-tihon
Copy link
Contributor

I like Option 3, but i think that it can be hard to recognize the difference in logo between Fable.Reaction and Fable, when logo completely in the same color schema.

I think that we should consider options with Rx color (at least somewhere) like option 8

Option 8

rxv8

@dbrattli
Copy link
Owner Author

dbrattli commented Nov 4, 2018

Yes, we could use the Rx color in the Logo of Fable.Reaction. Note also that in option 8 you are using the dragon head while option 3 uses the eel. If you want to separate it more with the Fable logo then we could use Rx colors for both, but have eel head on Reaction and dragon head on Fable.Reaction.

@sergey-tihon
Copy link
Contributor

sergey-tihon commented Nov 4, 2018

And only now I realized that you need two logos!
@dbrattli Could you please try these two in gitbook.

Reaction

rx

Fable.Reaction

frx

@dbrattli
Copy link
Owner Author

dbrattli commented Nov 4, 2018

This is much better now. Should I get a tatoo!?

skjermbilde 2018-11-04 kl 10 25 16

skjermbilde 2018-11-04 kl 10 30 15

@sergey-tihon
Copy link
Contributor

This is much better now. Should I get a tatoo!?

Tatoo is up to you ;)

I like these options because:

  • they looks unique
  • they similar to each and show relation between project
  • reaction version clearly similar to Rx
  • fable.reaction clearly similar to Fable

@dbrattli
Copy link
Owner Author

dbrattli commented Nov 4, 2018

Just testing the logos together with the gitbook documentation to get a better feeling of how they would look. Fable.Reaction looks great. Could perhaps have Rx colour on top part as well to separate more from Fable logo!? Unsure about Reaction. It would be cool if we should try the Rx shape (curled together) but with the dragon head, i.e a curled Fable dragon with Rx colors!?

skjermbilde 2018-11-04 kl 09 35 06

skjermbilde 2018-11-04 kl 09 34 34

@dbrattli
Copy link
Owner Author

dbrattli commented Nov 4, 2018

I really like them. Do you want to make a PRs to a /logo directory for each project. I'm going to need a .png version for the documentation. (not sure why one of my previous postings is stuck at the bottom of the discussion. Bug in github perhaps).

sergey-tihon added a commit to sergey-tihon/Fable.Reaction that referenced this issue Nov 4, 2018
Logo for Fable.Reaction - dbrattli#6
@sergey-tihon sergey-tihon mentioned this issue Nov 4, 2018
Merged
sergey-tihon added a commit to sergey-tihon/Reaction that referenced this issue Nov 4, 2018
Logo for Reaction - dbrattli/Fable.Reaction#6
@alfonsogarciacaro
Copy link

@dbrattli This is not exactly a topic for this issue, but how different are Reaction and Fable.Reaction? Is Reaction the base for Fable.Reaction, or one targets .NET while the other targets Fable? Do they have the same API?

I'm a bit concerned that having the two projects with different logos can be a bit confusing for the users. My suggestion would be to keep/promote a single project/repo (also unifying documentation) and use it to generate different packages for .NET/Fable. If Reaction is the base, and Fable.Reaction is just a way to apply to Elmish it may make sense to change the name to Elmish.Reaction.

For reference, Elmish itself dropped the Fable prefix in the project name when it started to be applied in other platforms (like Xamarin) but it still keeps the Fable.Elmish packages specifically targeting the browser. Thoth.Json is another example of a project that provides an API compatible with both .NET/Fable for easy code interop but has different packages depending on the platform.

BTW, it could be possible to have only one package and just use #if FABLE_COMPILER directives where Fable-specific code is needed (this is possible because Fable packages include the sources), but it may be easier to maintain two different packages.

@dbrattli
Copy link
Owner Author

dbrattli commented Nov 4, 2018

@alfonsogarciacaro Yes, Reaction is the base for Fable.Reaction, so I see your point that it can be confusing for users with the 2 different projects.

  • Reaction is similar to Control.Observable only that it adds an Async dimension, is dependency free and works with Fable. You can use it with ASP.NET Core, Giraffe for server side stream processing.
  • Fable.Reaction is most of all a Reactive-MVU specific architecture that hooks into Elmish, but you then use Reaction directly to do the actual transformation of the message stream. It adds a couple of Fable specific operators such as ofPromise, ofMouseMove and msgChannel.

So it might make sense to make this into one single project with 2 NuGet packages. Reaction and Fable.Elmish.Reaction. I'm no fan of #if FABLE_COMPILER since it confuses Ionide (#if !FABLE_COMPILER works better).

Reaction could probably be used with Xamarin also, but have never tried it. Then it could be called Elmish.Reaction if we made an assembly without the Fable specific operators.

@dbrattli
Copy link
Owner Author

dbrattli commented Nov 4, 2018

@alfonsogarciacaro But you could also argue that Reaction is to Fable(.Elmish).Reaction what RxJS is to Angular. Thus it could be that Fable.Reaction belongs with Elmish (https://github.com/elmish ) and should be moved there, but I haven't talked with Eugene so I don't know what he thinks of Fable/Reaction. Reaction might be moved to ReactiveX (http://reactivex.io/). Perhaps Reaction should be renamed to something Rx'ish to avoid confusion, FSharp.AsyncRx?

Thus we might want just want to keep the projects separate from now until we see how it goes.

@alfonsogarciacaro
Copy link

Hmm, I'm still afraid that having two projects with similar names (and very similar logos) is going to be confusing for the users (we had a similar discussion for Elmish.Remoting). For example, in the first page of the Reaction documentation it says it's designed with Fable in mind, but then users discover there's another package named Fable.Reaction. The difference may not be immediately obvious.

I would suggest:

  • If you want to focus on Fable/SAFE for now, try to unify the projects somehow. Maybe not putting them in the same repo, but unifying the documentation and having just one logo.
  • If you want to keep Reaction in the Rx family, it's probably a good idea to change the name to something like FSharp.AsyncRx as you suggest, reduce the references to Fable in the documentation (just say it's compatible with Fable but can be used in .NET projects too) and don't have a logo that explicitly references Fable.

In both cases, I'd rename Fable.Reaction to Elmish.Reaction and keep the logo from this comment which is tremendously cool 👏 👏

@alfonsogarciacaro
Copy link

BTW @sergey-tihon Is there any special tool you use for reshaping the SVG (the tail of the Rx eel) or you just move/rotate the curve points?

@dbrattli
Copy link
Owner Author

dbrattli commented Nov 4, 2018

@alfonsogarciacaro Refactoring as we speak 😄 The structure I'm going for is:

  1. Reaction will be deleted

  2. Fable.Reaction will be renamed to Reaction and contain the following dirs and packages:

  • AsyncRx (Reaction.AsyncRx.x.y.z.nupkg)
  • Elmish (Elmish.Reaction.x.y.z.nupkg), for use with Elmish without Fable
  • Fable.Elmish (Fable.Elmish.Reaction.x.y.z.nupkg), for use with Elmish and Fable

Docs will then be merged. Will this be OK?

@alfonsogarciacaro
Copy link

Sounds great, thank you!

@sergey-tihon
Copy link
Contributor

BTW @sergey-tihon Is there any special tool you use for reshaping the SVG (the tail of the Rx eel) or you just move/rotate the curve points?

I am just proxy in this case, i tell my wife what we need, what meaning we want to put in logo and what visual we expect. She give me image in the format that I asked ❤️. But as I know she draw it by hand in Adobe Illustrator.

@alfonsogarciacaro
Copy link

Great, thank your wife on our behalf! 🏅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

3 participants