Merge pull request #1 from jsgriffin/master

Fix a bug with replacing falsey values
dbrekalo · Nov 6, 2018 · 91b729d · 91b729d
2 parents 025755e + f9e8f59
commit 91b729d
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 1 deletion.
diff --git a/src/translate.js b/src/translate.js
@@ -33,7 +33,7 @@
             return translate.whenUndefined(key, locale);
         } else {
             return templateData ? translation.replace(interpolateRE, function(match, param) {
-                return templateData[param] || match;
+                return templateData.hasOwnProperty(param) ? templateData[param] : match;
             }) : translation;
         }
 

diff --git a/test/index.js b/test/index.js
@@ -97,6 +97,7 @@ describe('translate', function() {
         assert.equal(translate('welcomeMessage', {userName: 'George'}), 'Hello George');
         assert.equal(translate('welcomeMessage', {}), 'Hello {{userName}}');
         assert.equal(translate('taskCounterMessage', {taskCounter: 4, userName: 'George'}), '4 tasks left George');
+        assert.equal(translate('taskCounterMessage', {taskCounter: 0, userName: 'George'}), '0 tasks left George');
 
     });