Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop support for cdecimal #20

Merged
merged 1 commit into from Feb 10, 2020
Merged

Drop support for cdecimal #20

merged 1 commit into from Feb 10, 2020

Conversation

dbrgn
Copy link
Owner

@dbrgn dbrgn commented Feb 10, 2020

From https://stackoverflow.com/a/8192918/284318:

As of Python 3.3, the cdecimal implementation is now the built-in
implementation of the decimal standard library module, so you don't
need to install anything. Just use decimal.

Since combining decimal and cdecimal can result in weird bugs, and
since I will drop Python 2 support in the next release anyways,
supporting cdecimal doesn't make sense anymore.

@coveralls
Copy link

coveralls commented Feb 10, 2020

Coverage Status

Coverage decreased (-1.3%) to 61.111% when pulling f3790e9 on drop-cdecimal into 7f22f98 on master.

From https://stackoverflow.com/a/8192918/284318:

> As of Python 3.3, the cdecimal implementation is now the built-in
> implementation of the decimal standard library module, so you don't
> need to install anything. Just use decimal.

Since combining `decimal` and `cdecimal` can result in weird bugs, and
since I will drop Python 2 support in the next release anyways,
supporting `cdecimal` doesn't make sense anymore.
@dbrgn dbrgn merged commit da5c911 into master Feb 10, 2020
@dbrgn dbrgn deleted the drop-cdecimal branch February 10, 2020 10:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants