Override fields not init #7
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Prevent access to it, since it will be run and cached even when serializer is initialized as nested.
Previously it would warn if they were present but empty.
__init__ is called when creating the serializer instance. It can be during the request cycle or at django start time (nested serializer). Instead do the fields filtering logic directly in the `fields` property. Internal and external methods and properties use this public API for working with fields. It should be safe to assume `fields` is only accessed during the request cycle, so fetching `self.context` is assumed safe.
This situation would occur if someone was accessing `fields` during their own custom __init__ method.
I'm not convinced it is required.
I thought the code quality was good, but it requires docstrings on everything.
|
I've made changes (even to files I took from cookie-cutter) to keep the linter It seems like it doesn't acknowledge # noqa comments. I don't think I'm going to make any more changes since the code passes my flake8 linter here. |
|
#8 duplicate of this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not sure, but it might be nicer to move field related filtering into the
fieldsproperty rather than editing directly during__init__.