Add tol parameter to remove flattening tolerance constant #16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @naufraghi, I overlooked this PR, sorry about that. Could you rebase your branch on current master? Additionally, I fixed CI, so it should run for forked PRs as well now. |
naufraghi
force-pushed
the
3-add-tol-parameter-remove-FLATTENING_TOLERANCE
branch
from
608a229
to
2be957b
Compare
…arse() - update the ffi wrapper - tests are using the old const value Closes dbrgn#3
naufraghi
force-pushed
the
3-add-tol-parameter-remove-FLATTENING_TOLERANCE
branch
from
2be957b
to
41aa2cc
Compare
|
Thank you @naufraghi, and sorry for the long review delays! |
|
This feature is now released in 0.6.0. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the feature, but sometime adds the
tolparameter to an already long list of arguments.The other option I see is to create a struct and add functions there, but this has a downside on the FFI simplicity.
Feel free to close the PR if you are not interested in the patch or ask for modifications if you are!