Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update test reference for 'tar' tldr page #186

Merged
merged 1 commit into from May 9, 2021

Conversation

SimplyDanny
Copy link
Contributor

No description provided.

@dbrgn
Copy link
Owner

dbrgn commented May 9, 2021

Thanks! We should really switch away from tar (which is being updated quite often) to a rarely updated command.

@dbrgn dbrgn merged commit a92e974 into dbrgn:master May 9, 2021
@SimplyDanny SimplyDanny deleted the update-tar-reference branch May 11, 2021 05:20
@SimplyDanny
Copy link
Contributor Author

What about pages/common/pygmentize.md? It was last touched in 2017 and it is not overly simple and short.

@dbrgn
Copy link
Owner

dbrgn commented May 12, 2021

@SimplyDanny a PR that updates the test files would be welcome! We could also use the page for which. It's not simpler than pygmentize, but shorter.

@SimplyDanny
Copy link
Contributor Author

pages/common/which.md is pretty simple with respect to {{variables}}. I thought something more complex is preferred. We can also argue, though, that the integration test shall not test complex logic but just how everything works together. So if you like which more and think it is sufficient, I'm happy to open a PR to switch to it.

@dbrgn
Copy link
Owner

dbrgn commented May 12, 2021

Well, as long as it contains examples and variables, I think that's sufficient. Or do you see any complexity in pygmentize that's not in which?

@SimplyDanny
Copy link
Contributor Author

pygmentize has example code with multiple variables in one line with variable names not being just single words, like file names. But yeah, as said above, an integration test may use a simple example if the details are tested in other (unit) tests. So let's take which. 😉

@niklasmohrin
Copy link
Collaborator

We could also use the one for tldr, this way are guaranteed to notice any changes to the spec 😂

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants