Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for android platform #274

Merged
merged 2 commits into from
Jun 14, 2022
Merged

Add support for android platform #274

merged 2 commits into from
Jun 14, 2022

Conversation

newsch
Copy link
Contributor

@newsch newsch commented Jun 2, 2022

tldr added android-specific commands under a new 'android' platform last year: tldr-pages/tldr#5462

I think I caught all uses of the platform types, but another pair of eyes would be much appreciated!

tldr added android-specific commands under a new 'android' platform
last year: <tldr-pages/tldr#5462>
Copy link
Collaborator

@niklasmohrin niklasmohrin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Some remarks:

src/cli.rs Show resolved Hide resolved
src/types.rs Show resolved Hide resolved
Copy link
Collaborator

@niklasmohrin niklasmohrin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you :)

@newsch
Copy link
Contributor Author

newsch commented Jun 14, 2022

Thank you! I use tealdeer almost every day :)

Copy link
Owner

@dbrgn dbrgn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! LGTM as well 🙂

@dbrgn dbrgn merged commit 543fa22 into dbrgn:main Jun 14, 2022
@dbrgn dbrgn mentioned this pull request Jun 14, 2022
@newsch newsch deleted the android-platform branch June 14, 2022 22:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants