[#965] Escape delimiters in csv strings #1005
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
merando
requested changes
Oct 5, 2018
| @@ -72,7 +92,7 @@ public void testWriteWithDifferentPropertyTypes() throws Exception { | |||
| * Test CSVDataSink to properly separate the metadata | |||
| * of edges and vertices using the same label. | |||
| * | |||
| * @throws Exception | |||
| * @throws Exception on failure | |||
| /** | ||
| * Test CSVDataSink to properly escape strings and labels. | ||
| * | ||
| * @throws Exception on failure |
| /** | ||
| * Test CSVDataSink using existing a metadata.csv | ||
| * | ||
| * @throws Exception on failure |
| * Test IndexedCSVDataSink to properly escape strings and labels. The graph is created manually, | ||
| * since GDL does not support special characters. | ||
| * | ||
| * @throws Exception on failure |
| } | ||
|
|
||
| /** | ||
| * Test writing and reading a graph with an existing metadata file. | ||
| * | ||
| * @throws Exception on failure |
There was a problem hiding this comment.
Please add a specific exception msg.
merando
approved these changes
Oct 8, 2018
|
In my opinion, it is a bit over-engineered. Please have a look at the `StringEscapeUtils" class from the apache commons package. They are escaping strings in csv files with quotes, if there is a char inside that has to be escaped. It think, searching for chars with loops in the strings is not a good choice. In my opinion it is too much logic for exceptional cases, which would actually have to be done in a data-cleaning step. |
galpha
pushed a commit
to galpha/gradoop
that referenced
this pull request
Oct 9, 2018
0x002A
pushed a commit
to ChrizZz110/gradoop
that referenced
this pull request
Feb 19, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #965