Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix Snapshot Release + Bump deprecated github action versions #1599

Open
wants to merge 11 commits into
base: develop
Choose a base branch
from

Conversation

ChrizZz110
Copy link
Contributor

Description

  1. Snapshot release was creating a group id like org.gradoop.org.gradoop because a wrong suffic in the sonatype url in parent pom.xml. I have fixed this.
  2. Some of the versions used in github actions were deprecated. I cahnged them to the newest version.

Related Issue

#1598

Motivation and Context

Now the snapshot release will work properly.

How Has This Been Tested?

In my local repo with manual triggering the snapshot.

Types of Changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • I have updated the documentation accordingly (if necessary).
  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • I ran a spell checker.

@@ -142,7 +142,7 @@
</site>
<snapshotRepository>
<id>release_artifacts_gradoop</id>
<url>https://oss.sonatype.org/content/repositories/snapshots/org/gradoop</url>
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was a critical issue ... I added that suffix somewhen in 2022 but do not know why.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants