Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#994] Fix fromCollections method of GVEGraphLayoutFactory and add a test. #995

Merged
merged 2 commits into from Oct 4, 2018

Conversation

p-f
Copy link
Collaborator

@p-f p-f commented Sep 26, 2018

The method was previously not handling graph heads correctly.

Removed duplicate code and add a test for this method.

fixes #994

Copy link
Contributor

@merando merando left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link
Contributor

@ChrizZz110 ChrizZz110 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@merando merando merged commit eb212f4 into dbs-leipzig:develop Oct 4, 2018
@p-f p-f deleted the 994-gvelayoutfactory-fix branch October 4, 2018 13:26
0x002A pushed a commit to ChrizZz110/gradoop that referenced this pull request Feb 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

GVEGraphLayoutFactory.fromCollections ignores graph heads.
3 participants