Source Order Fix #6
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is going to be awesome, great work. I'll merge it up and shipt it, just give me a bit to review. ! |
cant seem to find a way to ignore circular dependencies....
dbsrgits-sync
force-pushed
the
people/TBSliver/source_order_fix
branch
from
fa1991c
to
caafa76
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for an issue where when inserting data into a database, the tables were being sorted alphabetically, rather than in dependency order. This meant that when a table such as
Authordepended on a table such asPublisherto already be populated, then the entire population step would fail - at least in PostgreSQL. This fix uses a stripped down version of the sorting algorithm from SQL::Translator.