Skip to content

Commit

Permalink
Expand notabs/eol testing to .pod and some files at the root
Browse files Browse the repository at this point in the history
  • Loading branch information
ribasushi committed Dec 18, 2012
1 parent a08e7b0 commit 7e1ca6d
Show file tree
Hide file tree
Showing 3 changed files with 53 additions and 5 deletions.
2 changes: 1 addition & 1 deletion script/dbicadmin
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@ my ($opts, $usage) = describe_options(
['Actions'],
["action" => hidden => { one_of => [
['create' => 'Create version diffs needs preversion'],
['upgrade' => 'Upgrade the database to the current schema '],
['upgrade' => 'Upgrade the database to the current schema'],
['install' => 'Install the schema version tables to an existing database'],
['deploy' => 'Deploy the schema to the database'],
['select' => 'Select data from the schema'],
Expand Down
28 changes: 26 additions & 2 deletions xt/eol.t
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@ use warnings;
use strict;

use Test::More;
use File::Glob 'bsd_glob';
use lib 't/lib';
use DBICTest;

Expand All @@ -13,12 +14,35 @@ unless ( DBIx::Class::Optional::Dependencies->req_ok_for ('test_eol') ) {
: plan skip_all => "Test needs: $missing"
}

# FIXME - temporary workaround for RT#82032
{
no warnings 'redefine';
*Test::EOL::_is_perl_module = sub {
$_[0] =~ /\.(?:pm|pod)$/i || $_[0] =~ /::/;
}
}

Test::EOL::all_perl_files_ok({ trailing_whitespace => 1 },
qw/t xt lib script examples maint/,
);

# Changes is not a "perl file", hence checked separately
Test::EOL::eol_unix_ok('Changes', { trailing_whitespace => 1 });
# check some non-"perl files" in the root separately
# use .gitignore as a guide of what to skip
# (or do not test at all if no .gitignore is found)
if (open(my $gi, '<', '.gitignore')) {
my $skipnames;
while (my $ln = <$gi>) {
next if $ln =~ /^\s*$/;
chomp $ln;
$skipnames->{$_}++ for bsd_glob($ln);
}

for my $fn (bsd_glob('*')) {
next if $skipnames->{$fn};
next unless -f $fn;
Test::EOL::eol_unix_ok($fn, { trailing_whitespace => 1 });
}
}

# FIXME - Test::EOL declares 'no_plan' which conflicts with done_testing
# https://github.com/schwern/test-more/issues/14
Expand Down
28 changes: 26 additions & 2 deletions xt/notabs.t
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@ use warnings;
use strict;

use Test::More;
use File::Glob 'bsd_glob';
use lib 't/lib';
use DBICTest;

Expand All @@ -13,12 +14,35 @@ unless ( DBIx::Class::Optional::Dependencies->req_ok_for ('test_notabs') ) {
: plan skip_all => "Test needs: $missing"
}

# FIXME - temporary workaround for RT#82033
{
no warnings 'redefine';
*Test::NoTabs::_is_perl_module = sub {
$_[0] =~ /\.(?:pm|pod)$/i || $_[0] =~ /::/;
}
}

Test::NoTabs::all_perl_files_ok(
qw/t xt lib script examples maint/,
);

# Changes is not a "perl file", hence checked separately
Test::NoTabs::notabs_ok('Changes');
# check some non-"perl files" in the root separately
# use .gitignore as a guide of what to skip
# (or do not test at all if no .gitignore is found)
if (open(my $gi, '<', '.gitignore')) {
my $skipnames;
while (my $ln = <$gi>) {
next if $ln =~ /^\s*$/;
chomp $ln;
$skipnames->{$_}++ for bsd_glob($ln);
}

for my $fn (bsd_glob('*')) {
next if $skipnames->{$fn};
next unless -f $fn;
Test::NoTabs::notabs_ok($fn);
}
}

# FIXME - Test::NoTabs declares 'no_plan' which conflicts with done_testing
# https://github.com/schwern/test-more/issues/14
Expand Down

0 comments on commit 7e1ca6d

Please sign in to comment.