Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix missing prereqs as reported by CPANTS. #8

Closed
wants to merge 1 commit into from

Conversation

manwar
Copy link

@manwar manwar commented Mar 1, 2017

Hi @dbsrgits

Please review the PR address the following issues:
http://cpants.cpanauthors.org/release/ILMARI/SQL-Abstract-1.81_01

Many Thanks.
Best Regards,
Mohammad S Anwar

@ilmari
Copy link
Member

ilmari commented Mar 1, 2017

Hi @manwar,

Sub::Quote used to be part of Moo (and is still required by it), so that should be added as an explicit prereq now that it's been split out. Fixed in commit 3d8630d.

However, DBIx::Class::Storage::Statistics is only used (as a base class) by the non-indexed DBIx::Class::Storage::Debug::PrettyPrint, which is used by DBIx::Class for debugging. SQL::Abstract must not depend on DBIx::Class, since it's used by it, and meant to be usable outside of it.

Regards,
Ilmari

@ilmari ilmari closed this Mar 1, 2017
@shadowcat-mst
Copy link
Member

cpants is sufficiently inaccurate that I'd recommend checking to see if the problems are actually problems before spending time on code.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants