-
-
Notifications
You must be signed in to change notification settings - Fork 86
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: use glue api to delete table instead of athena drop #249
Conversation
I'm not sure if any test cases need to be added. I haven't yet tested an incremental table but am planning to tomorrow. |
inside https://github.com/dbt-athena/dbt-athena/blob/main/dbt/include/athena/macros/materializations/models/table/table_hive_ha.sql#L42 please refactor the method to call |
dbt/include/athena/macros/materializations/models/table/table_hive_ha.sql
Outdated
Show resolved
Hide resolved
5fdbdd7
to
ff49a34
Compare
dbt/include/athena/macros/materializations/models/table/table_hive_ha.sql
Outdated
Show resolved
Hide resolved
4d1080f
to
f08552c
Compare
@Jrmyy would you mind to have a look at this one? |
@nicor88 There's no option for me to reply to this comment for some reason. I ran integration tests and there were a few that skipped but the ones that ran all passed. |
@chrischin478 do you think that you can add some unit tests for |
dbt/include/athena/macros/materializations/models/table/table.sql
Outdated
Show resolved
Hide resolved
4d0fc37
to
60fc619
Compare
dbt/include/athena/macros/materializations/models/table/table.sql
Outdated
Show resolved
Hide resolved
dbt/include/athena/macros/materializations/models/table/table.sql
Outdated
Show resolved
Hide resolved
a1855e4
to
d36c831
Compare
99eaec0
to
65882d1
Compare
Description
Feature #44. Use Glue API instead of Athena to drop tables and views.
Models used to test
Table
Iceberg Table
Hive HA Table
Incremental Table
Checklist