Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: seed method upload or insert #283

Closed

Conversation

brabster
Copy link
Contributor

@brabster brabster commented May 4, 2023

Description

resolve #279

Resolve issue #279, so that users can revert to pre-1.4.2 behaviour and avoid need for extra IAM permissions

Models used to test - Optional

Tests are in the change - I was unable to find a quick way of verifying that the insert vs. upload method had been used but I checked debug lots (a log message indicates which strategy) and query logs to confirm that the correct number of rows were queryable

Checklist

  • [/] You followed contributing section
  • [/] You kept your Pull Request small and focused on a single feature or bug fix.
  • [/] You added unit testing when necessary
  • [/] You added functional testing when necessary

@brabster brabster changed the title Seed method upload or insert fix: seed method upload or insert May 4, 2023
@brabster brabster marked this pull request as draft May 4, 2023 14:41
@brabster
Copy link
Contributor Author

brabster commented May 4, 2023

Confirmed can toggle between the two behaviours by setting the seed_by_insert flag in the appropriate connection profile in the project where I was having the problem upgrading, this will let us update past 1.4.2 ✔️

@brabster brabster mentioned this pull request May 8, 2023
@Jrmyy Jrmyy added this to the v1.5.1 milestone May 15, 2023
@brabster brabster closed this Jun 6, 2023
@brabster brabster deleted the seed-method-upload-or-insert branch June 12, 2023 19:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Seeds don't work without new permissions since 1.4.2
2 participants