fix: edge case fix on iceberg target table being dropped instead on being renamed first #667
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nicor88
requested review from
jessedobbelaere,
Jrmyy,
mattiamatrix and
svdimchenko
as code owners
nicor88
changed the title
nicor88
commented
Jun 4, 2024
dbt/include/athena/macros/materializations/models/table/table.sql
Outdated
Show resolved
Hide resolved
|
@octiva might give some input here, as he has a LF env with restricted policies, and we want to be sure that all works fine. |
Avinash-1394
reviewed
Jun 5, 2024
dbt/include/athena/macros/materializations/models/table/table.sql
Outdated
Show resolved
Hide resolved
octiva
reviewed
Jun 5, 2024
dbt/include/athena/macros/materializations/models/table/table.sql
Outdated
Show resolved
Hide resolved
octiva
reviewed
Jun 5, 2024
dbt/include/athena/macros/materializations/models/table/table.sql
Outdated
Show resolved
Hide resolved
|
@octiva it will be good if you can test this feature again in your environment to see if all works as expected. @Avinash-1394 I hope that I cover and addressed your question/suggestion. Feel free to have a look. |
octiva
approved these changes
Jun 5, 2024
dbt/include/athena/macros/materializations/models/table/table.sql
Outdated
Show resolved
Hide resolved
Co-authored-by: Spencer <53303191+octiva@users.noreply.github.com>
Jrmyy
approved these changes
Jun 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
See https://getdbt.slack.com/archives/C013MLFR7BQ/p1717497450266499
Pretty much #625 introduced a regression that was not letting iceberg working in an full high available mode.
This PR cover the issue, and add functional tests to catch these edge case.
Plus it introduce some improvements that allow to work properly in some restrictive LF permission models, where drop can happen only on existing objects.
Models used to test - Optional
See functional tests
Checklist