Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use None instead of NoReturn #113

Merged
merged 1 commit into from
Mar 22, 2023

Conversation

ian-r-rose
Copy link
Contributor

Fixes #112

@codecov-commenter
Copy link

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (3103262) 100.00% compared to head (40f2466) 100.00%.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

Additional details and impacted files
@@            Coverage Diff            @@
##              main      #113   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           47        47           
  Lines         2194      2194           
  Branches       272       272           
=========================================
  Hits          2194      2194           
Impacted Files Coverage Δ
dbt_checkpoint/generate_model_properties_file.py 100.00% <100.00%> (ø)
dbt_checkpoint/tracking.py 100.00% <100.00%> (ø)
dbt_checkpoint/unify_column_description.py 100.00% <100.00%> (ø)
dbt_checkpoint/utils.py 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Collaborator

@JFrackson JFrackson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me! From looking into it, this is definitely a mistake on the implementation and this corrects it to use the right type. This is explained well here for anyone else who is curious.

@JFrackson JFrackson merged commit a3a276c into dbt-checkpoint:main Mar 22, 2023
@ian-r-rose ian-r-rose deleted the fix-noreturn-usage branch March 22, 2023 18:27
@ian-r-rose
Copy link
Contributor Author

Thanks for the review and merge!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Incorrect usage of NoReturn
3 participants