Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: use proper tracking config file and document in README #115

Merged
merged 7 commits into from
Apr 3, 2023

Conversation

JFrackson
Copy link
Collaborator

This address #114 and patches another issue in the naming convention of the config that dbt-checkpoint was looking for. I've always verified now that no more "gloss" naming is used anywhere. Apologies for missing this in the last port of the dbt-gloss PR!

@JFrackson JFrackson self-assigned this Mar 22, 2023
@JFrackson JFrackson changed the title fix: gloss to checkpoint tracking fix: use proper tracking config file and document in README Mar 22, 2023
@codecov-commenter
Copy link

codecov-commenter commented Mar 22, 2023

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (a3a276c) 100.00% compared to head (3c1b79a) 100.00%.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

Additional details and impacted files
@@            Coverage Diff            @@
##              main      #115   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           47        47           
  Lines         2194      2206   +12     
  Branches       272       272           
=========================================
+ Hits          2194      2206   +12     
Impacted Files Coverage Δ
dbt_checkpoint/tracking.py 100.00% <100.00%> (ø)
dbt_checkpoint/utils.py 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@JFrackson JFrackson merged commit a055f90 into main Apr 3, 2023
@JFrackson JFrackson deleted the fix/gloss-to-checkpoint-tracking branch April 3, 2023 13:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants