Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix check-model-has-properties-file for snapshots #137

Merged
merged 2 commits into from
Dec 26, 2023

Conversation

ms32035
Copy link
Contributor

@ms32035 ms32035 commented Jun 22, 2023

Fixes #41

@codecov-commenter
Copy link

codecov-commenter commented Jun 22, 2023

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (f4b9b6c) 100.00% compared to head (ba05f1c) 100.00%.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

Additional details and impacted files
@@            Coverage Diff            @@
##              main      #137   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           47        47           
  Lines         2206      2210    +4     
  Branches       272       272           
=========================================
+ Hits          2206      2210    +4     
Impacted Files Coverage Δ
dbt_checkpoint/check_model_has_properties_file.py 100.00% <100.00%> (ø)
dbt_checkpoint/utils.py 100.00% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Collaborator

@BAntonellini BAntonellini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ms32035 thank you for contributing.

Could you extend test_check_model_has_properties_file covering this new get_snapshots logic?

@ms32035
Copy link
Contributor Author

ms32035 commented Dec 22, 2023

@BAntonellini a test has been added

@BAntonellini BAntonellini merged commit 94197e3 into dbt-checkpoint:main Dec 26, 2023
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Snapshots trigger check-model-has-properties-file
3 participants