Feat/check materialization by childs #144
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Given a threshold the hook compares the number of child models to it and decides whether the materialization should be changed accordingly.
The | operator is only included in later python versions. Therefore, removed it here to be compatible with lower python version.
Codecov ReportAttention:
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #144 +/- ##
==========================================
- Coverage 98.48% 98.38% -0.10%
==========================================
Files 49 50 +1
Lines 2443 2481 +38
Branches 319 322 +3
==========================================
+ Hits 2406 2441 +35
- Misses 21 24 +3
Partials 16 16 ☔ View full report in Codecov by Sentry. |
|
@LeopoldGabelmann thank you for your contribution. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi there,
here's an implementation of an idea that I had recently. The idea is that most often within a dbt project the materializations are not well used of and they are rather set on database or schema level. This hook can help to improve it.
Hope it's alright to include within this package, that way I could make use of the utils function. They are awesome btw :)
@BAntonellini @noel