Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature #136 #147

Merged
merged 3 commits into from
Dec 21, 2023
Merged

Conversation

johnerick-py
Copy link
Contributor

this feature seeks to solve the problem of issue #136, creating a new hook for labels, I tested it in a production environment where I call the hook to validate the model and everything is ok, but in the dbt-checkpoint repository I am having difficulties solving the unit tests , I will be grateful for any help or comments about.

…creating a new hook for labels, I tested it in a production environment where I call the hook to validate the model and everything is ok, but in the dbt-checkpoint repository I am having difficulties solving the unit tests , I will be grateful for any help or comments about.
@johnerick-py
Copy link
Contributor Author

As you can see in the github CI log, I'm having some problems validating in the unit test.

here's a print where I call the new hook and it validates the model without problems:
git

@codecov-commenter
Copy link

codecov-commenter commented Aug 14, 2023

Codecov Report

Patch coverage: 99.11% and project coverage change: +0.03% 🎉

Comparison is base (c57c8dd) 98.45% compared to head (e0a1e24) 98.48%.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #147      +/-   ##
==========================================
+ Coverage   98.45%   98.48%   +0.03%     
==========================================
  Files          47       49       +2     
  Lines        2330     2443     +113     
  Branches      309      319      +10     
==========================================
+ Hits         2294     2406     +112     
  Misses         21       21              
- Partials       15       16       +1     
Files Changed Coverage Δ
dbt_checkpoint/check_model_has_labels_keys.py 98.55% <98.55%> (ø)
dbt_checkpoint/check_source_has_labels_keys.py 100.00% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@BAntonellini
Copy link
Collaborator

@johnerick-py we've added documentation and setup configuration for these new hooks. Thank you for your contribution.

@BAntonellini BAntonellini merged commit 7cdb1e3 into dbt-checkpoint:main Dec 21, 2023
7 checks passed
@johnerick-py johnerick-py deleted the feature/labels-hook branch January 18, 2024 17:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants